-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use REST resource mapper #85
Conversation
Hi @toddtreece Thanks for the PR. The changes look good to me. |
Awesome @toddtreece ! I'm just taking a look at it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update examples/ingress_operations.js
as this is now broken. Get, List, and Delete operations now require a fully-qualified resource type (Ingress.networking.k8s.io
versus Ingress
).
Sorry that we have a ton of cruft in the examples directory...many can be ignored as we will be replacing most of them; ingress_operations.js
is a newer one that I knew should be working. We'll be getting full integration tests set up in the future.
💪 I was able to install a CRD (K6 type from k6-operator) and perform CRUD operations successfully as well.
yay! It would be nice to add an example of using CRDs 🤔 I'm creating and issue for that.
@javaducky maybe it is time to address this issue. Once we have a clear list of examples we want to maintain, I have some ideas of how to use them to implement #48 based on what I have been doing in xk6-disruptor. |
@toddtreece I renamed the PR because the title was misleading. Even when the motivation of the PR is to support CRDs the scope is basically introduce the REST mapper. If the scope were to introduce support for CRDs then we should had to add examples and tests for that, what we haven't done in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Why
This is an attempt to add support for custom resources.
Related issues:
What