Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support per-request headers (#33) #228

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

moeHaydar
Copy link
Contributor

@moeHaydar moeHaydar commented Nov 5, 2020

closes #33

Support passing custom header per request.
The functions (request and rawRequest) are backward-compatible.

@moeHaydar
Copy link
Contributor Author

@jasonkuhrt @schickling @timsuchanek @divyenduz
Tagging you for notification to see if we can move this forward :)

@schickling
Copy link
Contributor

LGTM. @jasonkuhrt leaving merging & releasing up to you :)

Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @moeHaydar! LGTM

@jasonkuhrt jasonkuhrt changed the title feat: Support per request headers (#33) feat: Support per-request headers (#33) Nov 16, 2020
Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing variable name

README.md Outdated Show resolved Hide resolved
examples/passing-custom-header-per-request.ts Outdated Show resolved Hide resolved
examples/passing-custom-header-per-request.ts Outdated Show resolved Hide resolved
@jasonkuhrt jasonkuhrt merged commit 952e972 into graffle-js:master Nov 16, 2020
@abenhamdine
Copy link

types haven't been updated in index.d.ts :

image

@abenhamdine
Copy link

abenhamdine commented Nov 28, 2020

types haven't been updated in index.d.ts :

sorry for the noise, I didn't notice this feature was in release 3.4.0-next.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to set header every request?
4 participants