Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include headers in ClientError response (#245) #246

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

emckay
Copy link
Contributor

@emckay emckay commented Jan 12, 2021

Fixes #245

This adds headers to ClientError in request the same way that it is done for rawRequest:

https://github.com/prisma-labs/graphql-request/blob/5b233c5658e65ed0d98cf8bff50beec413f399b9/src/index.ts#L71-L73

@emckay emckay force-pushed the emckay/headers-in-client-error branch from 4965135 to 2ea15ac Compare January 12, 2021 00:05
@emckay emckay force-pushed the emckay/headers-in-client-error branch from 2ea15ac to c510e3a Compare January 12, 2021 00:06
Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@jasonkuhrt jasonkuhrt merged commit a8d99f5 into graffle-js:master Jan 13, 2021
@emckay emckay deleted the emckay/headers-in-client-error branch January 13, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No headers on error response
2 participants