-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add signal support #303
feat!: add signal support #303
Conversation
I was just looking for a way to cancel requests with this lib and the changes in this PR will enable me to do just that. Thanks, @arnaudbzn! |
@jasonkuhrt Node.js supports
According to the README, we should not have to fully support v12. |
v12 is not officially supported so the impact should be minimal.
@jasonkuhrt , I've removed the Node v12 from the test matrix, everything should be green 🚦 |
@arnaudbzn Are there simple instructions for how Node 12 users can polyfill themselves? If so let's add that to our REDAME? |
Actually |
This reverts commit 7b37a45.
to support Node.js version < 14.17.0
@jasonkuhrt An |
Looking forward to using this. Can this be released? |
@jasonkuhrt Thank you for the merge 🙂 |
I'll cut a preview release today. Unfortunately the automation for that is still failing. |
@jasonkuhrt Thank you Jason, any update about the release? |
Preview went out 10 days ago, I can cut a stable today I guess. |
@jasonkuhrt Have you planned a release this week? Thks. |
@arnaudbzn we cut one last week, there's a problem with the release tool so no activity on the git repo about that. But it is on npm now. |
That's great! thank you Jason. |
Add a new
signal
request option torequest
,rawRequest
andbatchRequests
GraphQL Client methods.New GraphQL Client
request
,rawRequest
andbatchRequests
method overloads with a singleoptions
object argument.The
signal
defined as a function argument overrides the signal defined in theGraphQLClient
constructor.This feature will add more flexibility and it will allow GraphQL Code Gen React Query plugin to support
signal
and request cancellation with graphql-request.Related issue: #182
Also included in this PR:
yarn test:coverage
.