feat!: Invoke responseMiddleware in error cases as well #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkuhrt
approved these changes
Aug 2, 2022
jasonkuhrt
changed the title
tobilen
force-pushed
the
invoke-middleware-on-error
branch
from
7e54114 to
5de748c
Compare
|
thanks for the quick response! branch should be up to date now |
|
@jasonkuhrt anything missing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like the new middleware feature and would like to use it for some basic error handling.
Unfortunately, the current implementation only invokes the middleware if the fetch request has been resolved, meaning it will never get called on request failure.
BREAKING CHANGE:
Middleware will get either the response or error now, whereas before it would only get the response and never run in the error case.