-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove file uploads feature #501
Conversation
Any chance you can release a new version with this fix in it, e.g. v5.2.1 or v5.3.0? I'm having a build fail due to
|
@anulman can you confirm that the preview release works for you? |
Looks like it! Builds are succeeding; I'll report back if I see any issues. Tysm 🙏 |
this seems like a fairly big regression for users who were dependent on uploading files. how long was that feature in play for before it got removed? I assume if I am currently uploading files through graphql-request, that I should not upgrade the package for awhile? |
@avisra correct. |
Seems like a very big feature to take out of the package. |
file upload is an inevitability of building apps today. removing a feature like this, without a workaround, doesn't seem kosher. graphql packages leave a large code footprint - and replacing its implementation with another graphql library (which supports file upload) is not a task that can be completed overnight. fully aware this is an open source library, and you are free to do with it what you want. but removing a feature like this should really have gone through voting... The issue about removing file upload wasn't even live on github for a week. |
Nothing about what you have today has been broken. If it works for you stick with it. And when the feature returns, if it works for you, use it. PRs welcome guys. Thanks. |
closes #500