Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

MediaSegment@SeqId should be the media sequence of an individual segment? #116

Closed
leandromoreira opened this issue Aug 27, 2018 · 6 comments

Comments

@leandromoreira
Copy link

leandromoreira commented Aug 27, 2018

Each sub manifest has its initial (media) sequence number and I was under the impression that the attribute SeqId from the MediaSegment was the individual media sequence for that segment, am I right?

Also, I was browsing through the docs and also the source code and I couldn't find where the attribute SeqId is filled.

@leandromoreira
Copy link
Author

By the way, why did you pick SeqNo as uint64?

I think the type int64 might be enough, even if you pick an int32 type and a user sets each segment about 1s we would work for 70 years without wraparound.

@leandromoreira leandromoreira changed the title MediaSegment@SeqId should be the media sequence of that individual segment? MediaSegment@SeqId should be the media sequence of an individual segment? Aug 27, 2018
@leikao
Copy link
Collaborator

leikao commented Jan 18, 2019

By the way, why did you pick SeqNo as uint64?

Hi @leandromoreira , RFC 8216 defines the data type of SeqNo, the value range of decimal-integer is defined here.

o  decimal-integer: an unquoted string of characters from the set
   [0..9] expressing an integer in base-10 arithmetic in the range
   from 0 to 2^64-1 (18446744073709551615).  A decimal-integer may be
   from 1 to 20 characters long.

@leandromoreira
Copy link
Author

Thanks @leikao do you know why SeqId is not being set?

@leikao
Copy link
Collaborator

leikao commented Jan 21, 2019

Thanks @leikao do you know why SeqId is not being set?

Sorry @leandromoreira I don't know the reason why SeqId is not being set, may @grafov can give some points. You are welcome to submit a PR to improve this :)

@leikao
Copy link
Collaborator

leikao commented Jan 29, 2019

@leandromoreira I made a PR #124 to support MediaSegment@SeqId, welcome to try it :)

leikao added a commit that referenced this issue Feb 1, 2019
Feature: Support MediaSegment@SeqId, to close #107 #116
@leikao
Copy link
Collaborator

leikao commented Feb 1, 2019

PR #124 solved this issue, close it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants