This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
Append Args if playlist already has query params #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously media playlists were assumed to have no query parameters when encoding a master manifest with Args. This commit first checks if the URI contains existing params (checks for "?") and if so, appends new Args with a leading "&", else it will add "?".
|
It's also possible to redesign the args checking using Go's net/url package to parse the existing URI, but ultimately the url package is also checking for a ?, so I thought it wouldn't provide any more assistance without completely redesigning this section (and full supporting appending, encoding, per variant params etc). |
grafov
added a commit
that referenced
this pull request
Oct 17, 2015
Append Args if playlist already has query params
|
Probably 'net/url' is more right way but I think your solution is good enough. Merged ok, thank for this fix! |
grafov
added a commit
that referenced
this pull request
Nov 22, 2016
Append Args if playlist already has query params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously media playlists were assumed to have no query parameters when
encoding a master manifest with Args. This commit first checks if the
URI contains existing params (checks for "?") and if so, appends new
Args with a leading "&", else it will add "?".