[RFR] Added latency DA #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafuls
requested review from
KwisatzHaderach,
petr-balogh,
jan-zmeskal and
ILpinto
jan-zmeskal
reviewed
Jul 10, 2018
| cmd_add = "tc qdisc add dev eth0 root netem delay" | ||
| cmd_del = "tc qdisc del dev eth0 root netem delay" | ||
| result = await self.run_client(cmd_add) | ||
| wait = self.action.wait if self.action.wait else 10 |
There was a problem hiding this comment.
I think this is an use case for getattr. Also, I thank that the default wait time (10) should be either configurable or better expose. At least put it to coroutine docstring pls.
| if result: | ||
| rollback = await self.run_client(cmd_del) | ||
| if not rollback: | ||
| logger.info("Rollback was not successful") |
There was a problem hiding this comment.
Should not this be logger as a warning? Maybe ever error?
StLuke
reviewed
Jul 11, 2018
| result (bool): True if successful, False otherwise | ||
| """ | ||
| cmd_add = "tc qdisc add dev eth0 root netem delay" | ||
| cmd_del = "tc qdisc del dev eth0 root netem delay" |
There was a problem hiding this comment.
device eth0 should be configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36