Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 8.10 #140

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Update to Gradle 8.10 #140

merged 4 commits into from
Sep 13, 2024

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Sep 6, 2024

Requires the following PRs to be merged and snapshots to be published. Then passes all tests.

grails/grails-core#13622 - merged already
grails/grails-core#13630 - duplicate messageSource
grails/grails-views#581 - duplicate messageSource

-x test -x integrationTest can be removed from gradle.yml once the above PRs are completed.

.get()
.displayName

configurations.configureEach {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of dependencies were still pulling in org.codehaus.groovy at the time.


bootJar {
duplicatesStrategy = DuplicatesStrategy.INCLUDE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To work around duplicates that exist during the build. These were new after upgrade to gradle 8.10, but DuplicatesStrategy is set in other Grails projects.

@codeconsole codeconsole merged commit f40a14e into 7.0.x Sep 13, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants