7.0.x dependency cleanup

[codeconsole]

I think this will be a lot easier to maintain. All version numbers have been pulled out and the entire grails-core repo now uses its own bom for dependency version resolution.

I provided a more concise, clean approach to listing dependency versions. The previous way was a bit more tedious and time consuming having to add a map entry for every dependency.

Check out those deletion stats 😉

Still work needs to be done to analyze dependency configurations, but this can be done in a later ticket.

Spring Bom
Groovy Bom

[matrei]

The build is failing after the last cleanup commit 80534e7.
Could not find jline:jline: and Could not find com.github.javaparser:javaparser-core:

[matrei]

Great work Scott!

Can we add the versions as properties in the pom like in https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/3.3.4/spring-boot-dependencies-3.3.4.pom
Like it is for the plugins and profiles.
Then it is easy to override the version ext.set('spring.version', '6.1.13')

There is also some overlap between spring-boot-dependencies and grails-bom. Do we want to clean that up?

[matrei]

I'm missing some gsp modules here

[codeconsole]

what would you like added?

[matrei]

In grails-mail I wanted to use org.grails:grails-web-taglib but it is missing from the bom.
I guess all modules from grails-gsp should be added.

[codeconsole]

web can clean it up. we just need to identify the overlap and make sure the versions don't need to be overridden.
if they are the same version, we should remove.

[codeconsole]

adding the versioning is going to be a bit of work. I'd prefer to tackle that later. I made some attempts at it, but haven't had success yet. I haven't come up with or found a simple way of doing it yet. The previous version that worked was just building a maven bom which couldn't be used by the other projects. This is actually creating a bom type project.

[codeconsole]

@matrei I just didn't manually. Take a look, you have versions now

[matrei]

👍
Right now spock-core and spock-spring get included twice the pom.

[codeconsole]

fixed

[codeconsole]

added grails-web-taglib

[codeconsole]

The build is failing after the last cleanup commit 80534e7

I guess it doesn't like to resolve bom versions for documentation dependencies

        documentation("org.fusesource.jansi:jansi:$jansiVersion")
        documentation("jline:jline:$jlineVersion")
        documentation ("com.github.javaparser:javaparser-core:$javaParserCoreVersion")

I added reverted the versions back.

[matrei]

I guess it doesn't like to resolve bom versions for documentation dependencies

Wouldn't documentation platform(project(':grails-bom')) add it?

[jamesfredley]

The few comments, plus I'd like to add these:

org.gebish:geb-spock:7.0
com.bertramlabs.plugins:asset-pipeline-grails:5.0.1
org.grails.plugins:database-migration:6.0.0-SNAPSHOT

[codeconsole]

The few comments, plus I'd like to add these:
org.gebish:geb-spock:7.0 com.bertramlabs.plugins:asset-pipeline-grails:5.0.1 org.grails.plugins:database-migration:6.0.0-SNAPSHOT

@jamesfredley comments resolved, dependencies added

[matrei]

com.bertramlabs.plugins:asset-pipeline is not right. Did you mean asset-pipeline-core?
Also, these versions has historically been out of sync. For example, there is no asset-pipeline-grails:4.4.0.

[codeconsole]

ok, poor assumption on my part. removed.

[jamesfredley]

https://github.com/grails/grails-functional-tests/tree/skip-4-failing-tests passed all tests.

[codeconsole]

@matrei if I new I was going to make so many changes, I would have separated the task names a long time ago when you first asked. lol.

🤣

[matrei]

These are the version property names for the jakarta dependencies in spring-boot-dependencies that we duplicate. Should we try and keep the property names in sync or remove these dependences from grails-bom if we don't need to set different versions?
Right now our property names are jakarta-*-api.version

<jakarta-annotation.version>2.1.1</jakarta-annotation.version>
<jakarta-inject.version>2.0.1</jakarta-inject.version>
<jakarta-persistence.version>3.1.0</jakarta-persistence.version>
<jakarta-servlet.version>6.0.0</jakarta-servlet.version>
<jakarta-xml-bind.version>4.0.2</jakarta-xml-bind.version>

As much as I would like to support patch updates. The right thing is prob to resolve to Spring.

removed...