Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for grails.home set to not cause source to be fetched #347

Merged
merged 3 commits into from
Jul 30, 2015

Conversation

anshbansal
Copy link
Contributor

Fix #339

@anshbansal
Copy link
Contributor Author

Seems there is a problem. I will fix it today.

@graemerocher
Copy link
Member

The fix doesn't seem to work on the CI server

@anshbansal
Copy link
Contributor Author

@graemerocher I noticed that. Will send an updated PR.

@rlovtangen
Copy link
Contributor

Thanks, @anshbansal.
Would have been great to have this property in a file not under source control, though. gradle.properties is under source control, so when setting grails.home there, you need to make sure to not accidentally commit the change.

@jeffscottbrown
Copy link
Member

I think @rlovtangen makes a good point. Can we get this pulled out into a separate properties file?

@graemerocher
Copy link
Member

@jeffbrown @rlovtangen Why can't it just go into ~/.gradle/gradle.properties rather than adding more complexity?

@rlovtangen
Copy link
Contributor

@graemerocher yes, that's good enough for me. Needs to update patchesDoc.gdoc, then.

@anshbansal
Copy link
Contributor Author

updated the docs

graemerocher added a commit that referenced this pull request Jul 30, 2015
Fix for grails.home set to not cause source to be fetched
@graemerocher graemerocher merged commit 8076171 into grails:master Jul 30, 2015
jdaugherty pushed a commit that referenced this pull request Jan 16, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants