Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add functional test for grails-core#11767 #208

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

matrei
Copy link
Contributor

@matrei matrei commented Feb 19, 2024

matrei added a commit to matrei/grails-core that referenced this pull request Feb 19, 2024
This commit changes the behavior of the GrailsApplicationPostProcessor
so that it no longer creates a new plugin manager if a plugin manager
already exists in the application context.

Resolves grails#11767
Related grails/grails-functional-tests#208
puneetbehl pushed a commit to grails/grails-core that referenced this pull request Feb 20, 2024
This commit changes the behavior of the GrailsApplicationPostProcessor
so that it no longer creates a new plugin manager if a plugin manager
already exists in the application context.

Resolves #11767
Related grails/grails-functional-tests#208
@puneetbehl
Copy link
Contributor

Could you please look into the failing tests?

@matrei
Copy link
Contributor Author

matrei commented Feb 23, 2024

Could you please look into the failing tests?

That the tests failed is proof of the issue with loading plugin config values in Micronaut beans.
Now that grails/grails-core#13388 is merged they should pass if re-run.

However, I do not seem to have permission to re-run the jobs. Could you push the button?

@puneetbehl puneetbehl merged commit 85e7d81 into grails:6.1.x Mar 7, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants