Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grails-testing-support: re-enable views-json plugin and add dependsOn #438

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Oct 2, 2024

compileTestGroovy.dependsOn(compileGsonViews) added to resolve

Reason: Task ':examples-demo33:compileTestGroovy' uses this output of task ':examples-demo33:compileGsonViews' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':examples-demo33:compileGsonViews' as an input of ':examples-demo33:compileTestGroovy'.
      2. Declare an explicit dependency on ':examples-demo33:compileGsonViews' from ':examples-demo33:compileTestGroovy' using Task#dependsOn.
      3. Declare an explicit dependency on ':examples-demo33:compileGsonViews' from ':examples-demo33:compileTestGroovy' using Task#mustRunAfter.

@jamesfredley jamesfredley self-assigned this Oct 2, 2024
@jamesfredley jamesfredley changed the title re-enable views-json plugin and add dependsOn grails-testing-support: re-enable views-json plugin and add dependsOn Oct 3, 2024
@jamesfredley jamesfredley merged commit 136d7e7 into 4.0.x Oct 3, 2024
6 checks passed
@jamesfredley jamesfredley deleted the re-enable-views-json-plugin branch October 3, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants