Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli)!: Simplify version output #1291

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

phated
Copy link
Member

@phated phated commented May 31, 2022

This builds upon #1285 and needs #1290

Since #1290 ensures all versions are the same across the monorepo, we no longer need to output different versions for the CLI & compiler.

Simplifying the output so it only prints the version allows us to run grain doc stdlib -o stdlib --current-version=$(grain -v) in CI. See grain-lang/grain-lang.org#289

@phated phated requested a review from a team May 31, 2022 02:33
Base automatically changed from phated/commands-all-options to main June 1, 2022 20:09
@phated phated force-pushed the phated/cli-simple-version branch from dfc7f63 to 6624845 Compare June 1, 2022 20:11
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto!

@phated phated merged commit 97f99f4 into main Jun 2, 2022
@phated phated deleted the phated/cli-simple-version branch June 2, 2022 04:02
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants