Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set repr(C) on the Dsp struct to recover performance #889

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Set repr(C) on the Dsp struct to recover performance #889

merged 1 commit into from
Apr 23, 2023

Commits on Apr 23, 2023

  1. Set repr(C) on the Dsp struct to recover performance 

    After rust-lang/rust#102750 , Rust reorders
fields in repr(Rust) structures based on size/alignment. Applying such
reordering to the Dsp struct substantially hurts performance.

Set repr(C) on the Dsp struct to recover that performance.

See
https://internals.rust-lang.org/t/unexpected-3-x-performance-regression-starting-with-rust-version-1-67/18724
for the test case and investigations that led to this.
    @joshtriplett
    joshtriplett committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    65d784d View commit details
    Browse the repository at this point in the history