Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Staff Beaming Part 3 #96

Closed
arshiacont opened this issue Sep 27, 2019 · 2 comments
Closed

Cross Staff Beaming Part 3 #96

arshiacont opened this issue Sep 27, 2019 · 2 comments

Comments

@arshiacont
Copy link

arshiacont commented Sep 27, 2019

Fresh new Unit test:

{[ \staff<1>  
   \clef<"g2"> \key<-5> \meter<"C"> 
   \staff<2> \stemsUp \slurBegin:1<curve="down"> \beamBegin:1 \beamBegin:2 a&0/16 \staff<1> e&1/16 g&/16 \staff<2> g&0/16 \slurEnd:1  \beamEnd:2 \beamEnd:1 
  \slurBegin:1<curve="down"> \beamBegin:1 \beamBegin:2 a&/16 \staff<1> d&1/16 f/16 \staff<2> f0/16 \slurEnd:1 \beamEnd:2 \beamEnd:1 
   \slurBegin:1<curve="down"> \beamBegin:1 \beamBegin:2 a&/16 \staff<1> d&1/16 f/16 \staff<2> f0/16 \slurEnd:1 \beamEnd:2 \beamEnd:1 
   \slurBegin:1<curve="down"> \beamBegin:1 \beamBegin:2 a&/16 \staff<1> d&1/16 f/16 \staff<2> f0/16 \slurEnd:1 \beamEnd:2 \beamEnd:1 \staff<1> \bar  ]
 , 
[ \staff<2> \clef<"f4"> \key<-5> {a&-2/1, a&-1/1} \bar ]
  }

leading to:
image

Expected similar to:
image

@dfober
Copy link
Member

dfober commented Feb 24, 2020

partial fix: beaming is now correct but the slurs are a bit ugly and there is still the missing clefs and signatures on first staff (a headache!). (pushed to github)

dfober added a commit that referenced this issue Feb 24, 2020
@dfober
Copy link
Member

dfober commented Feb 26, 2020

fully fixed and pushed

@dfober dfober closed this as completed Feb 26, 2020
arshiacont added a commit to Antescofo/guidolib that referenced this issue Feb 22, 2022
….6.7

* commit '960bd5a5976e79ea5f60b348aebae70479db77c8':
  issues moved to regression tests
  change log
  fix slur issues: slurs tellPosition is now called after beaming is done
  remove commented code
  add isGRSlur method
  add methods (TopLeft and BottomRight)
  partial fix for issue grame-cncm#96
arshiacont added a commit to Antescofo/guidolib that referenced this issue Feb 22, 2022
….6.8

* commit '0994aaf8eafa2a655bd3e0605540577c7dd51c37':
  change log
  files moved to regression tests
  gmn update
  remove useless staff tags
  getOrder is now kDontMove (fix issue grame-cncm#96)
  useless include removed
  optimize tellPosition for fingering (empty first call)
  improve multi staff slurs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants