[PAL/Linux-SGX] Add ECONNRESET to errors allowed from ocall_recv
#709
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required)
a discussion (no related file):
Interesting that we already had this ECONNRESET in ocall_send() but not in ocall_recv(). Surely because of the man pages: it is mentioned in send, but not mentioned in recv.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Signed-off-by: Borys Popławski <borysp@invisiblethingslab.com>
boryspoplawski
force-pushed
the
borys/translate_econreset
branch
from
0a97638 to
f0419a8
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, all discussions resolved, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: ITL) (waiting on @boryspoplawski)
a discussion (no related file):
Thanks @boryspoplawski tested this PR with #693 and I no longer see below messages when I run lighttpd example.
> 02:17:17: connections.c.919) connection closed - read failed: Permission denied`
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @boryspoplawski)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vijaydhanraj)
a discussion (no related file):
Previously, vijaydhanraj (Vijay Dhanraj) wrote…
Thanks @boryspoplawski tested this PR with #693 and I no longer see below messages when I run
lighttpdexample.> 02:17:17: connections.c.919) connection closed - read failed: Permission denied`
@vijaydhanraj Why is this a blocking comment?
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
Previously, boryspoplawski (Borys Popławski) wrote…
@vijaydhanraj Why is this a blocking comment?
No, I didn't intend it to be blocking. I have resolved it.
Description of the changes
This cause
ECONNRESETto be translated toEPERMand confused the app. For examplelighttpdprinted error messaged, but continued to work.How to test this PR?
Try running
lighttpdexample as we do in CI.This change is