This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Fix mount loop processing to avoid crash on invalid path #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aacebedo
changed the title
| rel, err := filepath.Rel(mount.Destination, mountPath) | ||
| if err != nil { | ||
| return "", err | ||
| continue MountLoop |
There was a problem hiding this comment.
Wait. Why not just continue?
|
Documentation of golang describes the continue like this. However it shall be possible to use it without the label. If you prefer this I can rework the commit and retest it |
|
Re-read the doc and other example. Continue without label shall definitely do the job. I am going to edit the commit and repush it |
|
done pushed the modification |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of leaving the loop when an invalid path is encountered, I ignore it and pass to the next one.