This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Adopt image name splitting logic from docker #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: - https://github.com/docker/docker/blob/master/api/client/tag.go#L22-L30 - https://github.com/docker/docker/blob/master/pkg/parsers/parsers.go#L100-L118 - https://github.com/docker/docker/blob/a1c373197fe7f865ccac0ad338c213e3d1f863de/registry/config.go#L240-L251 - https://github.com/docker/docker/blob/a1c373197fe7f865ccac0ad338c213e3d1f863de/registry/config.go#L285-L300 Also, one of the tests was invalid, cause "hub" is not a valid registry. This can be checked by running this in command line: $ docker tag ubuntu hub/ns/name:1 ~/Projects/github/rocker 0 (tags-with-dots +) $ docker push hub/ns/name:1 The push refers to a repository [docker.io/hub/ns/name] (len: 1) 91e54dfb1179: Buffering to Disk unauthorized: access to the requested resource is not authorized
|
Hey, thanks! I will refactor it a bit after a merge to keep your PR in place. |
ybogdanov
pushed a commit
that referenced
this pull request
Oct 13, 2015
Adopt image name splitting logic from docker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Also, one of the tests was invalid, cause "hub" is not a valid registry.
This can be checked by running this in command line:
$ docker tag ubuntu hub/ns/name:1 ~/Projects/github/rocker 0 (tags-with-dots +) $ docker push hub/ns/name:1 The push refers to a repository [docker.io/hub/ns/name] (len: 1) 91e54dfb1179: Buffering to Disk unauthorized: access to the requested resource is not authorized