Fix Windows inability to handle a tilde as the home directory #43
Conversation
| @@ -48,7 +50,8 @@ type Config struct { | |||
| func NewConfig() *Config { | |||
| certPath := os.Getenv("DOCKER_CERT_PATH") | |||
| if certPath == "" { | |||
| certPath = "~/.docker" | |||
| usr, _ := user.Current() | |||
There was a problem hiding this comment.
this is not cross platform API, the build can pass with CGO, but at runtime it will throw error on some platform.
see also: http://stackoverflow.com/questions/7922270/obtain-users-home-directory
|
@missedone thanks! @tyrken can you try to incorporate https://github.com/mitchellh/go-homedir please? There are a few other places where it should be fixed, also there is rocker v1. So once you get it right with |
|
I've switched from os/user to go-homedir as requested - hopefully easy to copy elsewhere. Sorry for the slightly messy git history! |
Fix Windows inability to handle a tilde as the home directory
|
Thanks, @tyrken! |
The default location of the certificate files starting with a "~" (tilde) character causes Windows to barf. Follow some recommendations in http://stackoverflow.com/questions/17609732/expand-tilde-to-home-directory to fix.
Note that in my Windows/git-for-windows-2.5 environment some tests still fail (exec and volume mounting), but you can actually build the example Rockerfile. This also enables rocker-compose to work by default.