Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: built-in fluent integration #35

Merged
merged 13 commits into from
Feb 7, 2023
Merged

feat: built-in fluent integration #35

merged 13 commits into from
Feb 7, 2023

Conversation

dcdunkan
Copy link
Member

@dcdunkan dcdunkan commented Feb 1, 2023

Makes the Fluent class taken from better_fluent built-in.

There are several reasons for this change:

I don't think this has breaking changes in the point-of-view of i18n, because only the #30 changes are added in to I18n.

Feedback welcome.

deno.jsonc Outdated Show resolved Hide resolved
@KnorpelSenf KnorpelSenf requested a review from rojvv February 1, 2023 17:26
deno.jsonc Outdated Show resolved Hide resolved
scripts/dnt.ts Outdated Show resolved Hide resolved
examples/deno.ts Outdated Show resolved Hide resolved
scripts/dnt.ts Outdated Show resolved Hide resolved
src/deps.ts Outdated Show resolved Hide resolved
src/i18n.ts Outdated Show resolved Hide resolved
tests/deps.ts Outdated Show resolved Hide resolved
Co-authored-by: Roj <rojserbest@gmail.com>
Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/types.ts Outdated Show resolved Hide resolved
tests/deps.node.ts Outdated Show resolved Hide resolved
src/i18n.ts Outdated Show resolved Hide resolved
src/i18n.ts Outdated Show resolved Hide resolved
src/i18n.ts Outdated Show resolved Hide resolved
Co-authored-by: EdJoPaTo <rfc-conform-git-commit-email@funny-long-domain-label-everyone-hates-as-it-is-too-long.edjopato.de>
src/types.ts Show resolved Hide resolved
@KnorpelSenf KnorpelSenf merged commit 663d136 into main Feb 7, 2023
@KnorpelSenf KnorpelSenf deleted the fluent branch February 7, 2023 20:58
@KnorpelSenf
Copy link
Member

@dcdunkan or @EdJoPaTo feel free to release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants