Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the product changed warning when save product after modified at… #301

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Lurvy
Copy link

@Lurvy Lurvy commented Aug 5, 2022

Fixed the product changed warning when save product after modified attribute combination

Resolves #300
Type: bugfix

Issue

When save product after modified attribute combination there is a warning: "You can't edit the product because has been changed. Please refresh page and try to change again". If continue to click save, then "Product attributes" and "Attribute combinations" will could not add new or delete forever.

Modify attribute combination will change "UpdatedOnUtc" field of product, and when save product will verify the "Ticks" on page is equal "UpdatedOnUtc", but the "Ticks" is not newest.

Solution

Add newest "Product Ticks" to "Attribute Combination List", and change the hidden value "Ticks" on page after request list.

Breaking changes

Testing

1. Edit product, Click Tab "Inventory", Change "Manage inventory method" to "Track inventory by product attributes", Save it.
2. Add some "Product attributes" and checked "Allow to use in attribute combinations", add some "Attribute value".
3. Modify (Add / Delete / Generate / Clear) "Attribute combinations".
4. Click "Save" or "Save and Continue Edit".

Lurvy added 3 commits August 3, 2022 23:26
…ge attribute combination stock quantity will also write and clear the product cache frequently in a short period of time, that will cause cache can't clear
@Lurvy
Copy link
Author

Lurvy commented Aug 10, 2022

Fixed product cache issue: same as delete attribute combination, change attribute combination stock quantity will also write and clear the product cache frequently in a short period of time, that will cause cache can't clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When save product after modified attribute combination there is a warning.
1 participant