Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substituted TextView with AppCompatTextView #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrerinaldi
Copy link

@andrerinaldi andrerinaldi commented Jun 29, 2017

I think the library is really useful... but inheriting from TextView limits its usages: extending from AppCompatTextView the AutoFitTextView can benefit of newer attributes for fonts (like app:fontFamily=“…”) and for tints (app:drawableTint="...").

In order to help developers avoid conflicts with the version of the support library they use in their apps, you could edit the readme.md specifying that the library should be imported excluding the support package like this:

dependencies {
    compile ('me.grantland:autofittextview:0.2.+') {
        exclude group:'com.android.support'
    }
}

Hope it helps! :)

… new features like app:fontFamily=“…”
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant