Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type_abline deprecate aesthetics #265

Closed
vincentarelbundock opened this issue Nov 21, 2024 · 0 comments
Closed

type_abline deprecate aesthetics #265

vincentarelbundock opened this issue Nov 21, 2024 · 0 comments

Comments

@vincentarelbundock
Copy link
Collaborator

Currently type_abline() and friends all accept their own aesthetics like col and lty.

These arguments should not be in the type function. They should be governed by the top level tinyplot()
vincentarelbundock added a commit to vincentarelbundock/tinyplot that referenced this issue Nov 22, 2024
@vincentarelbundock
issue grantmcdermott#265
da1c200
vincentarelbundock added a commit that referenced this issue Nov 22, 2024
@vincentarelbundock
Merge pull request #266 from vincentarelbundock/issue265
4a272ce 
Issue #265 `col`, `lty` and friends should not be `type_abline()` arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vincentarelbundock