Coerce x/y/by from character to factor #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @zeileis! (Also for raising the caveat. Good to keep in mind and might necessitate a |
zeileis
commented
Sep 21, 2024
There was a problem hiding this comment.
Sorry, I'll try to remember the next time...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217
Summary: In
tinyplot.defaultthex,y, andbyvariables are turned into factors if they are character variables. This is done early on in the function but after alldeparse1(substitute(...))calls because the coercion would evaluate the variables obviously.Caveat: In the modular future we might have tinyplot types which want to draw character variables in some way. As long as the type "knows" that, it's not yet a killer argument. The plot type could coerce back with
as.character()and end up with the original variable. However, if that plot type would do somewhat different things for character variables and factor variables, then the design decision from this PR would prevent that.