fix(renovate): indexer-svc-rs wrong package #369
Conversation
WalkthroughThe pull request introduces changes to two files: Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
charts/firehose-ethereum/README.md (1)
246-246: Consider varying sentence beginnings for improved readability.In the values table, there are three successive entries that begin with the same word. While this doesn't affect the content's accuracy, varying the sentence structure could enhance readability.
Consider rephrasing some of the descriptions in the values table to avoid repetitive sentence beginnings. For example, you could use synonyms or restructure the sentences to add variety.
🧰 Tools
🪛 LanguageTool
[style] ~246-~246: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...vice | Service customization | object | `{"enabled":true,"metadata":{"annotations":{},"labels":{}},"spec":{"ports":{"fh-metrics":{"port":"{{ with .Pod.fireeth.metrics }}{{ .enabled | ternary (printf "%d" ( .port | int ) ) nil }}{{ end }}","protocol":"{{ with .Pod.fireeth.metrics }}{{ .enabled | ternar...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- .github/renovate.json5 (1 hunks)
- charts/firehose-ethereum/README.md (1 hunks)
🧰 Additional context used
🪛 LanguageTool
charts/firehose-ethereum/README.md
[style] ~246-~246: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...vice | Service customization | object | `{"enabled":true,"metadata":{"annotations":{},"labels":{}},"spec":{"ports":{"fh-metrics":{"port":"{{ with .Pod.fireeth.metrics }}{{ .enabled | ternary (printf "%d" ( .port | int ) ) nil }}{{ end }}","protocol":"{{ with .Pod.fireeth.metrics }}{{ .enabled | ternar...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🔇 Additional comments (3)
.github/renovate.json5 (1)
45-45: LGTM: Package name updated correctly.The package name has been updated from "indexer-rs" to "indexer-service-rs", which aligns with the PR objective. This change correctly addresses the wrong package name issue mentioned in the PR title.
To ensure this is the only occurrence of the old package name, let's run a quick check:
If this search returns no results, we can be confident that the package name has been updated correctly throughout the file.
✅ Verification successful
Verified: Package name updated correctly.
The search for any remaining instances of
"ghcr.io/graphprotocol/indexer-rs"returned no results, confirming that the package name has been successfully updated throughout the.github/renovate.json5file.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining instances of the old package name rg "ghcr.io/graphprotocol/indexer-rs" .github/renovate.json5Length of output: 60
charts/firehose-ethereum/README.md (2)
Line range hint
1-246: Excellent documentation improvements!The enhanced explanations for
firehoseComponentsandfirehoseServiceDefaultsprovide clear guidance on chart customization. The examples and details on configuration inheritance are particularly helpful for users setting up the Firehose-Ethereum components.🧰 Tools
🪛 LanguageTool
[style] ~246-~246: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...vice | Service customization | object | `{"enabled":true,"metadata":{"annotations":{},"labels":{}},"spec":{"ports":{"fh-metrics":{"port":"{{ with .Pod.fireeth.metrics }}{{ .enabled | ternary (printf "%d" ( .port | int ) ) nil }}{{ end }}","protocol":"{{ with .Pod.fireeth.metrics }}{{ .enabled | ternar...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Line range hint
1-246: Excellent documentation update!The changes to this README.md file significantly improve the Firehose-Ethereum Helm Chart documentation. The detailed explanations of
firehoseComponentsandfirehoseServiceDefaults, along with the comprehensive values table, provide users with clear guidance on chart customization and configuration options. These enhancements will greatly assist users in deploying and managing Firehose-Ethereum components.🧰 Tools
🪛 LanguageTool
[style] ~246-~246: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...vice | Service customization | object | `{"enabled":true,"metadata":{"annotations":{},"labels":{}},"spec":{"ports":{"fh-metrics":{"port":"{{ with .Pod.fireeth.metrics }}{{ .enabled | ternary (printf "%d" ( .port | int ) ) nil }}{{ end }}","protocol":"{{ with .Pod.fireeth.metrics }}{{ .enabled | ternar...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Summary by CodeRabbit
New Features
ghcr.io/graphprotocol/indexer-rsis nowghcr.io/graphprotocol/indexer-service-rs.Documentation