Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop legacy HHVM support due to lack of support and failing test suite #52

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Drop legacy HHVM support due to lack of support and failing test suite #52

merged 1 commit into from
Nov 2, 2022

Conversation

clue
Copy link
Member

@clue clue commented Oct 30, 2022

HHVM does not support PHP anymore and regularly causes our builds to fail, so no reason to keep legacy HHVM support around anymore.

Builds on top of #32, #51 and graphp/graph#211

@clue clue added this to the v0.9.0 milestone Oct 30, 2022
@clue clue requested a review from SimonFrings October 30, 2022 14:10
@clue
Copy link
Member Author

clue commented Oct 30, 2022

The build error is unrelated and being addressed in #51. On top of this, #51 currently fails because the HHVM build fails which is being addressed in this PR. My vote would be to merge #51 as is and then rebase this PR before merging.

@clue clue mentioned this pull request Oct 30, 2022
Merged
@clue
Copy link
Member Author

clue commented Oct 31, 2022

Rebased now that #51 has been merged :shipit:

@SimonFrings SimonFrings merged commit 2693893 into graphp:0.9.x Nov 2, 2022
@SimonFrings SimonFrings deleted the drop-hhvm branch November 2, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonFrings SimonFrings SimonFrings approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@clue @SimonFrings