Update documentation of attributes #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPDoc is fussy and doesn't want to allow nice inheritance of the documentation, so there is a fair bit of copy/paste here. The problems seemed to come down to interface inheritance perhaps not being fully supported. I think the class documentation is the most important bit here, the rest is just to help out IDEs and phpdoc generation to save user's a little effort. I'm not sure that the AttributeBagNamespaced not returning a fluent interface for its set* methods is correct, but I documented it the way it was implemented for now.
|
Awesome, this resolves one of the outstanding issues so that we can make some progress with #103. Thanks for the PR, keep it up 👍 |
clue
added a commit
that referenced
this pull request
Aug 7, 2014
Update documentation of attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.