#135 - Added removeAttribute method #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR @johnathanmdell, the changes LGTM! 👍 Issue #135 and this PR description only mentions removing attributes, but the changeset also includes a I'm 👍 on getting the We can look into working this out now, but I'm also okay with postponing this for a future PR. What's your take on this? |
|
The hasAttribute was purely habit, good point on the on the null value, I'm happy with removing it for the current PR. |
Removal of hasAttribute, will relook for future usage.
Removal of hasAttribute, will relook for future usage.
Removal of hasAttribute, will relook for future usage.
Removal of hasAttribute, will relook for future usage.
Removal of hasAttribute, will relook for future usage.
|
@clue PR updated |
|
Thanks @johnathanmdell, merged via #138! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to remove attributes
Closes #135