Move tests to the Fhaculty\Graph\Tests namespace #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, the change LGTM 👍 May I ask you to use 4 spaces in the |
Update composer.json to use autoload-dev to autoload the new Fhaculty\Graph\Tests namespace. Rename bootstrap.php to TestCase.php and remove the unnecessary include_once. Update phpunit.xml.dist to use vendor/autoload.php instead of tests/bootstrap.php.
tomzx
force-pushed
the
features/refactor-tests-to-namespace
branch
from
c2616a6 to
aa3d5be
Compare
|
Tabs in |
|
Thanks for your fast update, much appreciated, let's get this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update composer.json to use autoload-dev to autoload the new Fhaculty\Graph\Tests namespace.
Rename bootstrap.php to TestCase.php and remove the unnecessary include_once.
Update phpunit.xml.dist to use vendor/autoload.php instead of tests/bootstrap.php.