Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ordering vertices and edges by custom callbacks, remove all ORDER_* consts #181

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Support ordering vertices and edges by custom callbacks, remove all ORDER_* consts #181

merged 1 commit into from
Oct 7, 2019

Conversation

clue
Copy link
Member

@clue clue commented Oct 7, 2019 •
edited
Loading 

// old
$vertices->getVerticesOrder(Vertices::ORDER_ID);

// new
$vertices->getVerticesOrder(function (Vertex $vertex) {
    return $vertex->getId();
});

Among others, this is done in preparation for #114 (also refs #131). Builds on top of #180 and #179.

@clue clue added this to the v1.0.0 milestone Oct 7, 2019
@clue clue merged commit 7be2c14 into graphp:master Oct 7, 2019
@clue clue deleted the no-order-consts branch October 7, 2019 17:55
@clue clue mentioned this pull request Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC break new feature
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@clue