Allow set version for EIP721 domain separator #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That3Percent
approved these changes
Mar 7, 2022
| @@ -78,8 +79,14 @@ describe('Attestations', () => { | |||
| chainID, | |||
| contractAddress, | |||
| receipt, | |||
| '1.0.0', | |||
There was a problem hiding this comment.
According to the draft GIP, only versions of the form =MAJOR.MINOR.PATCH are valid for use in attestations. This is because MAJOR.MINOR.PATCH indicates a range. This is only a test, so it's not very important but for documentation's sake it may be a good idea to use =1.0.0 here.
There was a problem hiding this comment.
Good observation, done.
|
This is a breaking change on the attestation library that it now accepts and extra version parameter. I'll bump the major for the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.