Update near accounts docs #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azf20
suggested changes
Jun 23, 2022
pages/en/supported-networks/near.mdx
Outdated
| @@ -62,6 +62,13 @@ dataSources: | |||
| source: | |||
| account: app.good-morning.near # This data source will monitor this account | |||
| startBlock: 10662188 # Required for NEAR | |||
| accounts: | |||
There was a problem hiding this comment.
I think let's pull this out of the example manifest
pages/en/supported-networks/near.mdx
Outdated
| - NEAR data sources introduce an optional `source.accounts` field, which contains optional suffixes and prefixes. | ||
| At least prefix or suffix must be specified, they will match the any account starting or ending with the list of values respectively. | ||
| For the provided example it would match: `[app|good].*[morning.near|morning.testnet]`. If only a list of prefixes or suffixes is necessary | ||
| the other field can be omitted. |
There was a problem hiding this comment.
I think let's drop the example above here in a code block
pages/en/supported-networks/near.mdx
Outdated
| - good | ||
| suffixes: | ||
| - morning.near | ||
| - morning.testnet |
There was a problem hiding this comment.
I think remove the testnet from here, as it's mixing networks which isn't technically possible, so this is potentially confusing
|
Could we rebase this for the new structure @mangas ? |
mangas
force-pushed
the
update-near-docs-accounts
branch
from
0bc0b2b to
c0cc1c9
Compare
mangas
force-pushed
the
update-near-docs-accounts
branch
from
c0cc1c9 to
f518ae4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.