node: Make sure Config.node is set correctly

graphprotocol · Aug 4, 2022 · 209786c · 209786c
1 parent 8a61a0e
commit 209786c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/node/src/config.rs b/node/src/config.rs
@@ -150,7 +150,7 @@ impl Config {
     /// a config from the command line arguments in `opt`
     pub fn load(logger: &Logger, opt: &Opt) -> Result<Config> {
         if let Some(config) = &opt.config {
-            Self::from_file(logger, config)
+            Self::from_file(logger, config, &opt.node_id)
         } else {
             info!(
                 logger,
@@ -160,13 +160,15 @@ impl Config {
         }
     }
 
-    pub fn from_file(logger: &Logger, path: &str) -> Result<Config> {
+    pub fn from_file(logger: &Logger, path: &str, node: &str) -> Result<Config> {
         info!(logger, "Reading configuration file `{}`", path);
-        Self::from_str(&read_to_string(path)?)
+        Self::from_str(&read_to_string(path)?, node)
     }
 
-    pub fn from_str(config: &str) -> Result<Config> {
+    pub fn from_str(config: &str, node: &str) -> Result<Config> {
         let mut config: Config = toml::from_str(&config)?;
+        config.node =
+            NodeId::new(node.clone()).map_err(|()| anyhow!("invalid node id {}", node))?;
         config.validate()?;
         Ok(config)
     }

diff --git a/tests/src/fixture.rs b/tests/src/fixture.rs
@@ -126,7 +126,7 @@ pub async fn stores(store_config_path: &str) -> Stores {
             Err(e) => panic!("{}", e.to_string()),
         };
         let config = config.replace("$THEGRAPH_STORE_POSTGRES_DIESEL_URL", &db_url);
-        Config::from_str(&config).expect("failed to create configuration")
+        Config::from_str(&config, "default").expect("failed to create configuration")
     };
 
     let logger = graph::log::logger(true);