Add graphman rewind
#2373
Merged
Add graphman rewind
#2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannis
reviewed
Apr 12, 2021
Comment on lines
+969
to
+984
| // Sanity check on block numbers | ||
| if block_ptr_from.number != block_ptr_to.number + 1 { | ||
| panic!("revert_block_operations must revert a single block only"); | ||
| } |
There was a problem hiding this comment.
Is this just here because we revert block by block usually? It's not here because reverting many blocks at once breaks things?
There was a problem hiding this comment.
It probably used to be that we had to go block-by-block; but for quite some time now, it's been safe to jump the block pointer back (assuming you know that you are jumping to the correct block pointer, which this PR slyly puts on the user) All the reversion queries just look at things that happened at/after the given block.
I left that code in since I didn't want to muck with the 'normal' reversion code path.
Jannis
reviewed
Apr 12, 2021
Jannis
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.