node: Refactor config to accept Firehose provider #2647
Conversation
… a little bit more extensible)
There is a backward compatible handling of config that at some point should be converted to the new syntax form. The new syntax form is
```
{ label = "node0", details = { type = "web3", transport = "rpc", url = "...", features = [...] } }
```
While a Firehose provider now looks like:
```
{ label = "firehose0", details = { type = "firehose", url = "..." } }
```
This is for now undocumented and is first step towards Firehose integration in the codebase directly.
|
@otaviopace @tilacog When you have a few spare minutes, you like a review here. Feel free to ping someone else with more knowledge of this part if required. |
|
I think @lutter is the ideal person to review this. |
|
Excellent! Can we have it merged now hehe :0 |
|
@maoueh the way we usually do is that once a PR is approved, we let for the author to merge it whenever is better for them 🙂 The cases we want/need to wait for something else to go first or depend on another thing (maybe running the integration tests on that branch), people usually warn in the approve comment. I would just double check if it's fine with @leoyvens in this case because I remember him mentioning that for one of your PRs he was waiting on something related to the tokio one to review or merge (I'm not quite sure honestly). |
|
@otaviopace It's good, we got access now, so I'm able to approve now. |
… a little bit more extensible) (graphprotocol#2647) There is a backward compatible handling of config that at some point should be converted to the new syntax form. The new syntax form is ``` { label = "node0", details = { type = "web3", transport = "rpc", url = "...", features = [...] } } ``` While a Firehose provider now looks like: ``` { label = "firehose0", details = { type = "firehose", url = "..." } } ``` This is for now undocumented and is first step towards Firehose integration in the codebase directly.
… a little bit more extensible) (#2647) (#2698) There is a backward compatible handling of config that at some point should be converted to the new syntax form. The new syntax form is ``` { label = "node0", details = { type = "web3", transport = "rpc", url = "...", features = [...] } } ``` While a Firehose provider now looks like: ``` { label = "firehose0", details = { type = "firehose", url = "..." } } ``` This is for now undocumented and is first step towards Firehose integration in the codebase directly.
(and made Provide a little bit more extensible along the way)
There is a backward compatible handling of config that at some point should be converted to the new syntax form. The new syntax form is
While a Firehose provider now looks like:
This is for now undocumented and is first step towards Firehose integration in the codebase directly.