Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphman fix block command #3270

Merged
merged 11 commits into from
May 3, 2022
Merged

graphman fix block command #3270

merged 11 commits into from
May 3, 2022

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Feb 23, 2022 •
edited
Loading

Adds a new graphman command, that can be used either to:

  1. compare, diff and prune cached blocks against freshly obtained ones from the configured JRPC provider, or
  2. truncate an entire block cache (for a given chain)

@tilacog tilacog mentioned this pull request Feb 25, 2022
Open
tilacog
tilacog commented Mar 2, 2022
View reviewed changes
node/Cargo.toml Show resolved Hide resolved
tilacog
tilacog commented Mar 2, 2022
View reviewed changes
node/src/manager/commands/fix_block.rs Outdated
Ok(())
}

mod steps {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are lots of common steps, I've chosen to group them in submodules and reuse them in the topmost module.

@tilacog tilacog requested a review from lutter March 2, 2022 16:28
@tilacog
Copy link
Contributor Author

tilacog commented Apr 4, 2022

I'll rebase this on top of #3416 to account for the new DeploymentLocator struct.

@tilacog tilacog force-pushed the tiago/graphman-fix-block-command branch from d8872d1 to 4404d89 Compare April 4, 2022 18:51
lutter
lutter requested changes Apr 8, 2022
View reviewed changes
node/src/bin/manager.rs Show resolved Hide resolved
node/src/bin/manager.rs Outdated Show resolved Hide resolved
node/src/bin/manager.rs Outdated Show resolved Hide resolved
node/src/bin/manager.rs Outdated Show resolved Hide resolved
node/src/bin/manager.rs Outdated Show resolved Hide resolved
node/src/manager/commands/fix_block.rs Outdated Show resolved Hide resolved
node/src/manager/commands/fix_block.rs Outdated Show resolved Hide resolved
@azf20
Copy link
Contributor

azf20 commented Apr 29, 2022

@tilacog nudging on the status of this?

@tilacog
Copy link
Contributor Author

tilacog commented Apr 29, 2022

I still have to implement the requested changes. I'll try to find some time today to work on them.

@tilacog tilacog requested a review from lutter April 29, 2022 19:57
lutter
lutter approved these changes May 2, 2022
View reviewed changes
Copy link
Collaborator

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this will be very useful to a lot of people

@tilacog tilacog merged commit f84e6b8 into master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lutter lutter lutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tilacog @azf20 @lutter