Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firehose connection pool #3833

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Firehose connection pool #3833

merged 2 commits into from
Aug 10, 2022

Conversation

leoyvens
Copy link
Collaborator

@leoyvens leoyvens commented Aug 9, 2022

This adds a conn_pool_size field to the toml configuration of firehose providers, which enables load balancing across multiple connections to the provider's endpoint. It defaults to 10.

Also does some refactoring around FirehoseEndpoint::new.

@leoyvens leoyvens requested a review from sduchesneau August 9, 2022 16:32
@leoyvens leoyvens force-pushed the leo/firehose-connection-pool branch from 33691af to 98ec76b Compare August 9, 2022 16:42
Copy link
Contributor

@sduchesneau sduchesneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@sduchesneau
Copy link
Contributor

Just need to check the tests that are hanging though!

@leoyvens leoyvens force-pushed the leo/firehose-connection-pool branch from 98ec76b to 6484d01 Compare August 9, 2022 18:25
@leoyvens
Copy link
Collaborator Author

leoyvens commented Aug 9, 2022

oops, fixed test

@leoyvens leoyvens merged commit d039f08 into master Aug 10, 2022
@leoyvens leoyvens deleted the leo/firehose-connection-pool branch August 10, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants