Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: use exec form for CMD directive #4186

Closed
wants to merge 0 commits into from
Closed

docker: use exec form for CMD directive #4186

wants to merge 0 commits into from

Conversation

islishude
Copy link
Contributor

the CMD start is equal with CMD sh -c start, so pid of graph node is not 1

image

@islishude
Copy link
Contributor Author

@lutter Hi, can you please take a look?

@leoyvens leoyvens requested a review from neysofu November 30, 2022 18:58
@leoyvens
Copy link
Collaborator

@islishude there seem to be CI issues, could you please rebase the branch?

@islishude islishude closed this Dec 1, 2022
@islishude islishude mentioned this pull request Dec 1, 2022
Merged
@islishude
Copy link
Contributor Author

just filed a new pull request #4217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neysofu neysofu Awaiting requested review from neysofu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@islishude @leoyvens