Add a flag to graphman to list all deployments #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
changed the title
lutter
requested changes
Feb 13, 2023
|
@lutter Im not sure why the integration tests fail, let me know if i can mark this PR ready for review. |
lutter
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
This looks great, and is ready to be merged (pending some unrelated fixes to our CI)
Before merging, can you squash all the commits into one and use this commit message:
node: Add a flag to graphman to list all deployments
Fixes https://github.com/graphprotocol/graph-node/issues/3407
1dd4613 to
0bff87f
Compare
|
The integration tests are fixed now; just rebase your changes on top of the latest master, and all checks should pass |
incrypto32
force-pushed
the
incrypto32/graphman-list-all
branch
from
0bff87f to
e5d11d0
Compare
incrypto32
force-pushed
the
incrypto32/graphman-list-all
branch
from
e5d11d0 to
43e54e0
Compare
|
@lutter looks like all tests passed! |
|
Sorry, totally forgot about this. Yes, this is good to be merged now; you'll need to rebase and resolve the merge conflict before doing that. Please follow the steps explained here on how to merge the PR |
incrypto32
force-pushed
the
incrypto32/graphman-list-all
branch
from
43e54e0 to
f2ac0bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3407