-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql: update introspection schema #4676
Conversation
363f4c5
to
f53172e
Compare
Do the tests cover the added fields? We should make sure that they do, particularly because non-nullable fields were added. |
f53172e
to
f810f35
Compare
since it is a |
@saihaj didn't know that, is that in the graphql spec somewhere? |
I just added a commit to this PR that fixes the test failures. When we execute a query, the schema we use for that is a combination of the subgraph schema and the introspection schema. When we mix the introspection schema into the subgraph schema, we add the two introspection fields to the subgraph schema's |
Updating the introspection schema as per October 2021 spec update - http://spec.graphql.org/October2021/#sec-Schema-Introspection.Schema-Introspection-Schema