Refactor graphman rewind to use pause and resume logic
#5213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
reviewed
Feb 20, 2024
incrypto32
requested changes
Mar 11, 2024
itsjerryokolo
force-pushed
the
graphman-rewind
branch
from
8d0050f to
290198f
Compare
incrypto32
reviewed
Apr 15, 2024
incrypto32
reviewed
Apr 15, 2024
…ionality to the Context struct,
Co-authored-by: Krishnanand V P <44740264+incrypto32@users.noreply.github.com>
Co-authored-by: Krishnanand V P <44740264+incrypto32@users.noreply.github.com>
Co-authored-by: Krishnanand V P <44740264+incrypto32@users.noreply.github.com>
…d constant in rewind.rs
itsjerryokolo
force-pushed
the
graphman-rewind
branch
from
ddbc490 to
2561613
Compare
incrypto32
requested changes
May 1, 2024
incrypto32
approved these changes
May 6, 2024
incrypto32
added a commit
that referenced
this pull request
Jun 6, 2024
* Refactor deployment pause and resume logic * Refactor pause_and_resume to use DeploymentLocator, Add cloning functionality to the Context struct, * Update node/src/manager/commands/rewind.rs Co-authored-by: Krishnanand V P <44740264+incrypto32@users.noreply.github.com> * Update node/src/bin/manager.rs Co-authored-by: Krishnanand V P <44740264+incrypto32@users.noreply.github.com> * Update node/src/bin/manager.rs Co-authored-by: Krishnanand V P <44740264+incrypto32@users.noreply.github.com> * Refactor cloning and pausing logic in manager.rs and rewind.rs * Refactor code to use mutable connection in assign.rs and remove unused constant in rewind.rs * removing cloning in manager.rs * minor refactoring * node: throw an error when a deployment search matches more than one in rewind --------- Co-authored-by: Krishnanand V P <44740264+incrypto32@users.noreply.github.com> Co-authored-by: incrypto32 <vpkrishnanand@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
graphman rewindcommand to use the pause and resume function.