store: Avoid 'too many bind params' error in FindDerivedEntityQuery #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FindDerivedQuery would contain a clause `id not in (<lots of values>)` where each entry in the list is a separate bind variable. If we have more than 65k derived entities already loaded into memory, this would require more bind variables than what Postgres supports. With this change, we pass those values as one array and therefore only need one bind variable.
lutter
force-pushed
the
lutter/load-derived
branch
from
3862506
to
86cce05
Compare
leoyvens
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FindDerivedQuery would contain a clause
id not in (<lots of values>)where each entry in the list is a separate bind variable. If we have more than 65k derived entities already loaded into memory, this would require more bind variables than what Postgres supports. With this change, we pass those values as one array and therefore only need one bind variable.