Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat.Req] Limit number of receipts per RAV request #96

Closed
aasseman opened this issue Nov 14, 2023 · 1 comment · Fixed by #159 or #194
Closed

[Feat.Req] Limit number of receipts per RAV request #96

aasseman opened this issue Nov 14, 2023 · 1 comment · Fixed by #159 or #194
Assignees
Labels
p1 High priority size:medium Medium type:feature New or enhanced functionality

Comments

@aasseman
Copy link
Contributor

Problem statement
TAP Agent will currently try to send all unaggregated receipts with a RAV request.
The TAP Aggregator will currently not accept more than 10MB of data per request (otherwise would be a DoS vector). It was therefore decided that the TAP Aggregator should be guaranteed to handle a maximum of 15,000 receipts per call.

Expectation proposal
Implement the logic that will only pull up to 15,000 oldest unaggregated receipts per RAV request, as well as continuing to do more RAV requests if there should be more than 15,000 receipts to aggregate.
This will involve changes in https://github.com/semiotic-ai/timeline-aggregation-protocol/tree/main/tap_core.

Additional context
https://github.com/semiotic-ai/timeline-aggregation-protocol/blob/main/tap_aggregator/README.md

@aasseman aasseman added size:medium Medium p1 High priority type:feature New or enhanced functionality labels Nov 14, 2023
@aasseman aasseman added this to the TAP Agent ready for prod milestone Nov 14, 2023
@aasseman aasseman assigned aasseman and unassigned aasseman Nov 14, 2023
@aasseman aasseman self-assigned this Nov 15, 2023
@aasseman
Copy link
Contributor Author

Working on the tap_core prerequisite: semiotic-ai/timeline-aggregation-protocol#190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:medium Medium type:feature New or enhanced functionality
Projects
None yet
2 participants