Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit of receipts per rav request #159

Merged
merged 3 commits into from
May 3, 2024
Merged

Add limit of receipts per rav request #159

merged 3 commits into from
May 3, 2024

Conversation

carlosvdr
Copy link
Collaborator

@carlosvdr carlosvdr commented May 2, 2024 •
edited
Loading

Added to config a limit that will define the amount of receipts to aggregate per request
fixes #96

@carlosvdr carlosvdr self-assigned this May 2, 2024
@coveralls
Copy link

coveralls commented May 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8930750641

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 67.062%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/config.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
tap-agent/src/agent/sender_allocation.rs 1 82.88%
Totals Coverage Status
Change from base Build 8915992245: -0.05%
Covered Lines: 3337
Relevant Lines: 4976
💛 - Coveralls

@carlosvdr carlosvdr linked an issue May 2, 2024 that may be closed by this pull request
Limit number of receipts to aggregate #143
Closed
@carlosvdr carlosvdr removed a link to an issue May 2, 2024
Limit number of receipts to aggregate #143
Closed
@carlosvdr carlosvdr changed the title Add receipt limit Add limit of receipts per rav reques May 2, 2024
@carlosvdr carlosvdr changed the title Add limit of receipts per rav reques Add limit of receipts per rav request May 2, 2024
aasseman
aasseman reviewed May 2, 2024
View reviewed changes
tap-agent/src/config.rs Outdated Show resolved Hide resolved
tap-agent/src/config.rs Outdated Show resolved Hide resolved
@aasseman aasseman merged commit 1966049 into main May 3, 2024
8 checks passed
@aasseman aasseman deleted the limit-rav-amount branch May 3, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman left review comments

@gusinacio gusinacio gusinacio approved these changes

Assignees

@carlosvdr carlosvdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat.Req] Limit number of receipts per RAV request
4 participants
@carlosvdr @coveralls @gusinacio @aasseman