Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unresolved promise rejections caused by ethers.js #183

Closed
Jannis opened this issue Dec 30, 2020 · 1 comment · Fixed by graphprotocol/common-ts#60
Closed

Unresolved promise rejections caused by ethers.js #183

Jannis opened this issue Dec 30, 2020 · 1 comment · Fixed by graphprotocol/common-ts#60
Labels
bug Something isn't working indexer-agent indexer-service

Comments

@Jannis
Copy link
Contributor

Jannis commented Dec 30, 2020

For reference: ethers-io/ethers.js#1208

It looks like after a while, ethers.js always runs into this. One way to work around the problem could be to re-initialize a few of the runtime components, like the StaticJsonRpcProvider. This may be a pretty involved workaround, so it would be preferable if ethers.js could be made more robust.
@Jannis Jannis added bug Something isn't working indexer-service indexer-agent labels Dec 30, 2020
@Jannis
Copy link
Contributor Author

Jannis commented Jan 5, 2021

I reworked the agent to recreate the Ethereum provider every 10 minutes but after only 2 minutes it starts throwing unresolved promise rejections again. So that idea doesn't cut it as a workaround.

@Jannis Jannis mentioned this issue Jan 6, 2021
Closed
@Jannis Jannis mentioned this issue Jan 15, 2021
Merged
Jannis added a commit that referenced this issue Jan 15, 2021
@Jannis
*: Update ethers to 5.0.26 (#183)
a2b51f2 
ethers 5.0.26 includes a fix for ethers-io/ethers.js#1208,
which should remove the unresolved promise rejections we've seen in #183.
@Jannis Jannis mentioned this issue Jan 15, 2021
Merged
Jannis added a commit that referenced this issue Jan 15, 2021
@Jannis
*: Update ethers to 5.0.26 (#183)
dc20e2e 
ethers 5.0.26 includes a fix for ethers-io/ethers.js#1208,
which should remove the unresolved promise rejections we've seen in #183.
fordN pushed a commit that referenced this issue Mar 15, 2021
@Jannis @fordN
*: Update ethers to 5.0.26 (#183)
cb2f718 
ethers 5.0.26 includes a fix for ethers-io/ethers.js#1208,
which should remove the unresolved promise rejections we've seen in #183.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working indexer-agent indexer-service
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ethers to 5.0.26 graphprotocol/common-ts
1 participant
@Jannis