Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor dta auth cookie when using the schema plugin in a main rails project route #233

Merged
merged 4 commits into from
Aug 14, 2022

Conversation

00dav00
Copy link
Contributor

@00dav00 00dav00 commented Aug 7, 2022

This is related to this discussion

This change will allow cookies to be set when using the schema plugin a route from the main rails project, the default route used when using mount_graphql_devise_for to mount the engine route still needs some changes to be able to set cookies.

Changes

  • Fix DTA callabck not executed on:
    • login
    • register
    • update passowrd with token

@00dav00 00dav00 force-pushed the honor-dta-auth-cookie branch from bd5e6ce to 5440bc2 Compare August 7, 2022 12:00
@00dav00 00dav00 requested a review from mcelicalderon August 9, 2022 06:57
@00dav00 00dav00 force-pushed the honor-dta-auth-cookie branch from 724c4bd to d2b192b Compare August 13, 2022 07:33
@00dav00 00dav00 force-pushed the honor-dta-auth-cookie branch from d2b192b to 1e434c1 Compare August 13, 2022 07:45
Copy link
Member

@mcelicalderon mcelicalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@00dav00 00dav00 changed the title Honor dta auth cookie Honor dta auth cookie when using the schema plugin a main rails project route Aug 14, 2022
@00dav00 00dav00 changed the title Honor dta auth cookie when using the schema plugin a main rails project route Honor dta auth cookie when using the schema plugin in a main rails project route Aug 14, 2022
@00dav00 00dav00 merged commit dd45f57 into master Aug 14, 2022
@00dav00 00dav00 deleted the honor-dta-auth-cookie branch August 14, 2022 05:57
@mcelicalderon mcelicalderon added the bug Something isn't working label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants