Uneccessary execution error wrapping

[BilyachenkoOY]

After rewriting my original solution using GraphQL.Conventions I fall into the issue that I can't handle errors as easily as before. For example, this code is not working anymore:

// filtering by type
var criticalErros = result.Errors?.Except(result.Errors.OfType<DeprecatedNodeExecutionError>());
// or filtering by custom code
var criticalErros = result.Errors?.Where(e => e.Code != "DEPRECATED_NODE");

This is because of some two-lever errors wrapping which is made in GraphQLEngine.cs#L289.

• So, is there any reason for such wrapping which makes it harder to determine my errors later and changes some data (ExecutionError.Code which i set in original error is overridden with class name)?
• And if so, how can I manage such situation?

[huysentruitw]

Coincidence or not, I've just opened this issue 30 minutes ago 🙂

[huysentruitw]

While writing the unit-tests for this PR #122
I've figured that, without custom error transformation, the level of nesting is the same. So I'm not sure if it'll help anything?

[tlil]

@BilyachenkoOY can you comment on whether @huysentruitw PR helps you or not?

[BilyachenkoOY]

@tlil, @huysentruitw I checked PR and it is fine for me, since my issue was about errors added with middleware and not about thrown exceptions. And now those errors are preserved as I'd expect.
As for thrown exceptions, now I'll be able to write own transformation to unwrap such errors.

So, thank you for this PR!