Add EF Core based DataLoader sample with queries and mutation #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlil
reviewed
Oct 17, 2018
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="AutoMapper" Version="7.0.1" /> | ||
| <PackageReference Include="GraphQL.Conventions" Version="2.0.1" /> |
There was a problem hiding this comment.
Could potentially use a project reference here?
There was a problem hiding this comment.
Do you want me to include the sample project in the main .sln file? (Only in that case a project reference would be better)
|
|
||
| public string CountryCode { get; set; } | ||
|
|
||
| public Guid MovieId { get; set; } |
There was a problem hiding this comment.
Do you want this one in the schema? If you want to link to movie, perhaps having a movies { ... } field is more useful? :-)
There was a problem hiding this comment.
Yeah it's a bit an odd FK, but I wanted a 1 to many relation to demonstrate the use of a CollectionBatchLoader. Maybe we need to use a different use-case. Suggestions are welcome.
There was a problem hiding this comment.
Hmm, I see. Let's leave it like this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.